Hi, On 07/31/2015 02:00 PM, Robert ABEL wrote: > > This patch series completely reworks Xilinx' XIIC driver. Short summary: > Driver didn't work for me and I don't know how it could ever have worked for anybody. > So I rewrote it in big parts and now it works for me™. > > Due to how the XIIC IP core is written, certain operations have to be done in short succession > before XIIC is able to send out a single word over I2C. The original code didn't take this into > account. The original code also doesn't expect bus faults, so undefined behavior will happen > on spurious interrupts while using the driver. > > There are still two issues in there which I think might preclude proper SMBus operation, see patch 4 notes. > However these issues are also in the original code, so there's no regression here. > > The bulk of the work is in patch 4 as are the bulk of patch series comments about driver behavior. > > Regards > > Robert > > This patch series depends on: (https://github.com/Xilinx/linux-xlnx) > > 36bc779 i2c: xiic: Do not continue in case of errors in Rx > 875c2be i2c: xiic: Remove the disabling of interrupts > 2abc522 i2c: xiic: move the xiic_process to thread context > ec52523 i2c: xiic: Do not reset controller before every transfer > 3d1f868 i2c: xiic: Remove the disabling of interrupts > 0b018f2 i2c: xiic: Remove busy loop while waiting for bus busy > 5fc498e i2c: xiic: Add a msg in case of timeout > b4272fe i2c: xiic: Remove the Addressed as slave interrupt > 3a0fd6c i2c: xiic: Service all interrupts in isr > > Patch 6 depends on: (mainline) > > 37786c7 of: Add helper function to check MMIO register endianness > 65a7100 of: Document {little,big,native}-endian bindings > I am confused. Do you want to change xilinx tree or mainline? You are using public mailing list that's why all you patches have to be based on the mainline repository not xilinx tree. Please rebase and resent. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
