From: Jan Lübbe <mailto:jlu@xxxxxxxxxxxxxx> Sent: Thursday, July 16, 2015 8:58 PM > To: Gao Pan-B54642 > Cc: Uwe Kleine-König; wsa@xxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; Li > Frank-B20596; Duan Fugang-B38611 > Subject: Re: [Patch v1] i2c: imx: implement bus recovery > > On Di, 2015-07-14 at 08:12 +0000, Gao Pandy wrote: > > > > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.txt > > > > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.txt > > > > @@ -14,6 +14,8 @@ Optional properties: > > > > The absence of the propoerty indicates the default frequency > > 100 kHz. > > > > - dmas: A list of two dma specifiers, one for each entry in > > dma-names. > > > > - dma-names: should contain "tx" and "rx". > > > > +- recover-scl: specify the gpio related to SCL pin > > > > +- recover-sda: specify the gpio related to SDA pin > > > I don't like the naming here. That the gpios are used for recovery > > isn't > > > a hardware description. What about "scl-gpio" and "sda-gpio"? > > > > Thanks. I will change it in the next version. > > There is already a binding for i2c-gpio: > Documentation/devicetree/bindings/i2c/i2c-gpio.txt > > We should be able to reuse those properties as-is, instead of defining > something for each i2c controller binding. Thanks. The hardware description in i2c-gpio.txt describes the case of i2c gpio. However, in our patch, we just want the sda and scl pins change to gpio mode for bus recovery, after recovery, we set the two pins to i2c function, i2c host controller will take over the transfer. So it's a different case. Once we use the hardware description in i2c-gpio.txt, additional gpios should be applied. Correspondingly, it also need plentiful code support. ��.n��������+%������w��{.n�����{��-��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
