Re: [PATCHv2 6/9] i2c: xiic: Add a debug msg in case of timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 9, 2015 at 10:59 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> On Wed, Jun 17, 2015 at 08:48:16PM +0530, Shubhrajyoti Datta wrote:
>> Currently we return silently upon a timeout.
>> Adding an error message to aid debugability. Not
>>  a functional change.
>>
>> Signed-off-by: Shubhrajyoti Datta <shubhraj@xxxxxxxxxx>
>
> I am not in favour of this. In case of a stalled bus, this can easily
> flood the logs. If it is for debugging, it should also be dev_dbg. And
> then, it probably can also be added when needed. I mean the errno is
> quite descriptive, no?
>
I agree I had added it for debugging.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux