On Sat, 20 Jun 2015, Antonio Borneo wrote:
> > Signed-off-by: Ellen Wang <ellen@xxxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/hid/hid-cp2112.c | 74 ++++++++++++++++++++++++++++++++++------------
> > 1 file changed, 55 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
> > index 5a72819..00d062a 100644
> > --- a/drivers/hid/hid-cp2112.c
> > +++ b/drivers/hid/hid-cp2112.c
> > @@ -153,6 +153,7 @@ MODULE_DEVICE_TABLE(hid, cp2112_devices);
> > struct cp2112_device {
> > struct i2c_adapter adap;
> > struct hid_device *hdev;
> > + int hwversion;
>
> No need for int; u8 is enough (value is copyed from buf[2] that is u8).
> Put the new u8 field few lines below, together with the other u8, to
> avoid extra padding.
>
> No need to send immediately a new version. Let's see if there is any
> other comment and if someone can test it before me.
Antonio, is there any result of your testing? I have put this patch on
hold waiting for your word on it, but it has been ~3 weeks already.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
