Re: [PATCH RFC] i2c: octeon: allow receiving of signals.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 11, 2015 at 03:23:52PM +0200, Nicholas Mc Guire wrote:
> Change wait_event_timeout() to wait_event_interruptible_timeout() allowing
> signals to be received while waiting on event (task state set to 
> TASK_INTERRUPTIBLE) as the dev_dbg() string indicates that signals
> are expected to be possible. While at it fix the type to long (as returned
> by schedule_timeout(). 
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> ---
> 
> From the dev_dbg string "wait interrupted" it seems that interrupts are
> expected to be on - so most likely this should be
> wait_event_interruptible_timeout() and not wait_event_timeout() as the
> later return >= 0 always and sets the task state to TASK_UNINTERRUPTIBLE.
> Someone that knows the details of this driver needs to confirm this though.

Use 'git log drivers/i2c/busses/i2c-octeon.c' and you will find commit
2637e5fd232d421b680757944f613d4b1a36ae26 which disabled the signals.
For further digging, you could do
'git log --grep="interruptible" drivers/i2c/busses' to find that signals
cause a lot of problems with i2c transactions.

Summary: The code still handling signal code simply needs to go.

Thanks,

   Wolfram

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux