Re: [PATCH 02/12] i2c: pxa: No need to set slave addr for i2c master mode reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Saturday 30 May 2015 12:51 AM, Robert Jarzmik wrote:
Vaibhav Hiremath <vaibhav.hiremath@xxxxxxxxxx> writes:

diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index f4ac8c5..d4c798a 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -459,8 +459,10 @@ static void i2c_pxa_reset(struct pxa_i2c *i2c)
  	writel(I2C_ISR_INIT, _ISR(i2c));
  	writel(readl(_ICR(i2c)) & ~ICR_UR, _ICR(i2c));

+#ifdef CONFIG_I2C_PXA_SLAVE
  	if (i2c->reg_isar)
  		writel(i2c->slave_addr, _ISAR(i2c));
+#endif
I'd rather have :
   	if (i2c->reg_isar && IS_ENABLED(CONFIG_I2C_PXA_SLAVE))
   		writel(i2c->slave_addr, _ISAR(i2c));


Ok,
Will fix it in next version.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux