On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> Modify i2c-parport driver to use the new parallel port device model.
>
> Tested-by: Jean Delvare <jdelvare@xxxxxxx>
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
In general:
Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> static struct parport_driver i2c_parport_driver = {
> - .name = "i2c-parport",
> - .attach = i2c_parport_attach,
> - .detach = i2c_parport_detach,
> + .name = "i2c-parport",
> + .match_port = i2c_parport_attach,
> + .detach = i2c_parport_detach,
> + .devmodel = true,
Minor nit: I prefer to not use tabs but a single space after the struct
member names. Less hazzle in the future and still readable IMO.
Attachment:
signature.asc
Description: Digital signature
