Alexey Brodkin <Alexey.Brodkin@xxxxxxxxxxxx> wrote on 03/09/2015 10:03:12 AM: > From: Alexey Brodkin <Alexey.Brodkin@xxxxxxxxxxxx> > To: linux-i2c@xxxxxxxxxxxxxxx, > Cc: linux-kernel@xxxxxxxxxxxxxxx, Alexey Brodkin > <Alexey.Brodkin@xxxxxxxxxxxx>, Vineet Gupta > <Vineet.Gupta1@xxxxxxxxxxxx>, Christian Ruppert > <christian.ruppert@xxxxxxxxxx>, Mika Westerberg > <mika.westerberg@xxxxxxxxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxxxxx>, > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Date: 03/09/2015 10:03 AM > > As discussed here https://lkml.org/lkml/2015/3/3/568 and here > https://lkml.org/lkml/2015/3/3/453 we're looking forward for > implementing warnings and errors outputs right in platform_get_irq() > instead of having all kind of different outputs in each and every driver > that uses platform_get_irq(). > > Signed-off-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx> > Cc: Vineet Gupta <vgupta@xxxxxxxxxxxx> > Cc: Christian Ruppert <christian.ruppert@xxxxxxxxxx> Acked-by: Christian Ruppert <christian.ruppert@xxxxxxxxxxx> Please note that my email address has changed and use the alitech one in future. The abilis address might be switched off soon. > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/ > i2c/busses/i2c-designware-platdrv.c > index c270f5f..fa4e2b5 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -143,10 +143,8 @@ static int dw_i2c_probe(struct platform_device *pdev) > u32 clk_freq, ht = 0; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "no irq resource?\n"); > - return irq; /* -ENXIO */ > - } > + if (irq < 0) > + return irq; > > dev = devm_kzalloc(&pdev->dev, sizeof(struct dw_i2c_dev), GFP_KERNEL); > if (!dev) > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
