On Tue, 2015-03-03 at 18:46 +0100, Christian Ruppert wrote: > On 2015-03-03 18:21, Wolfram Sang wrote: > > > >> which omit this type of messages completely. Andy's proposal of > >> centralising this looks like a very good solution here (and on > >> top of that removes many useless strings from the kernel > >> binary). > > > > I am all for centralizing printouts. I recommended this at my ELCE > > talk last year, too. However, you need to keep in mind that irqs > > are sometimes optional and you don't want error messages for those > > irqs. IMO worthwhile, but not a low hanging fruit... > > There is a lot of truth in that. Thus the initial dev_dbg() suggestion > to go half way. I still think that Andy's proposal (or a variation > thereof to catch the optional irqs case) should be the ultimate goal > but I agree that this is more than a quick patch and that it's > probably way out of scope here. Yes, I was thinking even about some wrapper on top of platform_get_irq() since it seems there are no messaging done inside platform.c, though devm_* functions usually have it. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
