On Wed, 11 Feb 2015 14:32:04 +0200, Jarkko Nikula wrote:
> It makes more difficult to grep these error prints from sources if they are
> split to multiple source lines.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-i801.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 8fafb254e42a..7d1f4a478c54 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1192,8 +1192,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> /* Determine the address of the SMBus area */
> priv->smba = pci_resource_start(dev, SMBBAR);
> if (!priv->smba) {
> - dev_err(&dev->dev, "SMBus base address uninitialized, "
> - "upgrade BIOS\n");
> + dev_err(&dev->dev,
> + "SMBus base address uninitialized, upgrade BIOS\n");
> err = -ENODEV;
> goto exit;
> }
> @@ -1206,8 +1206,9 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
>
> err = pci_request_region(dev, SMBBAR, i801_driver.name);
> if (err) {
> - dev_err(&dev->dev, "Failed to request SMBus region "
> - "0x%lx-0x%Lx\n", priv->smba,
> + dev_err(&dev->dev,
> + "Failed to request SMBus region 0x%lx-0x%Lx\n",
> + priv->smba,
> (unsigned long long)pci_resource_end(dev, SMBBAR));
> goto exit;
> }
Looks good.
Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
