Re: [PATCH v3] i2c: i2c-ocores: add common clock support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +#ifdef CONFIG_HAVE_CLK
> +	if (!IS_ERR(i2c->clk))
> +		clk_disable_unprepare(i2c->clk);
> +#endif

Ehrm, you can leave out all the #ifdeffery :) The functions are all
empty in the !HAVE_CLK scenario. The only one which might be left is the
pointer in the struct. I'll leave it to you if you want to save the
bytes or the lines of code.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux