Re: [PATCH v1 3/3] i2c: designware-pci: no need to provide clk_khz

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/22/2015 04:44 PM, Andy Shevchenko wrote:
The clk_khz field makes sense only if SS counters are not provided. Since we
provide them for Haswell and Baytrail explicitly we can omit the clk_khz
parameter.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
  drivers/i2c/busses/i2c-designware-pcidrv.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index 2bbd2a7..506cbe8 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -112,7 +112,6 @@ static struct dw_pci_controller dw_pci_controllers[] = {
  		.bus_cfg = INTEL_MID_STD_CFG | DW_IC_CON_SPEED_FAST,
  		.tx_fifo_depth = 32,
  		.rx_fifo_depth = 32,
-		.clk_khz = 100000,
  		.functionality = I2C_FUNC_10BIT_ADDR,
  		.scl_sda_cfg = &byt_config,
  	},
@@ -121,7 +120,6 @@ static struct dw_pci_controller dw_pci_controllers[] = {
  		.bus_cfg = INTEL_MID_STD_CFG | DW_IC_CON_SPEED_FAST,
  		.tx_fifo_depth = 32,
  		.rx_fifo_depth = 32,
-		.clk_khz = 100000,
  		.functionality = I2C_FUNC_10BIT_ADDR,
  		.scl_sda_cfg = &hsw_config,
  	},

Yes, there are no other use for the clock rate than calculate these SS counters in drivers/i2c/busses/i2c-designware-core.c, and which will get overwritten by provided values.

Reviewed-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux