Hi Andy, Am Mittwoch, den 07.01.2015, 02:36 +0000 schrieb fugang.duan@xxxxxxxxxxxxx: > From: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Sent: Tuesday, January 06, 2015 10:48 PM > > To: Wolfram Sang > > Cc: linux-i2c@xxxxxxxxxxxxxxx; Duan Fugang-B38611; Yuan Yao-B46683; > > Estevam Fabio-R49496; kernel@xxxxxxxxxxxxxx; Philipp Zabel > > Subject: [PATCH 3/3] i2c: imx: whitespace and checkpatch cleanup > > > > This patch fixes up some whitespace issues and addresses a few checkpatch > > warnings. > > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > --- > > drivers/i2c/busses/i2c-imx.c | 53 ++++++++++++++++++++++++++------------ > > ------ > > 1 file changed, 32 insertions(+), 21 deletions(-) > > [snip] > > if (i == (msgs->len - 1)) { > > if (is_lastmsg) { > > /* > > - * It must generate STOP before read I2DR to > > prevent > > - * controller from generating another clock cycle > > + * It must generate STOP before read I2DR to > > + * prevent controller from generating another > > + * clock cycle > > */ > > It is better for the format: > /* It must generate STOP before read I2DR to Thank you for the review, but according to Documentation/CodingStyle this multi-line comment format is only preferred for code in net/ and drivers/net. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html