RE: [PATCH 2/3] i2c: imx: remove unused return value assignments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
Sent: Tuesday, January 06, 2015 10:48 PM
> To: Wolfram Sang
> Cc: linux-i2c@xxxxxxxxxxxxxxx; Duan Fugang-B38611; Yuan Yao-B46683;
> Estevam Fabio-R49496; kernel@xxxxxxxxxxxxxx; Philipp Zabel
> Subject: [PATCH 2/3] i2c: imx: remove unused return value assignments
> 
> The ret variable is set and never used in the error path of
> i2c_imx_dma_request.
> 
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-imx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index f0d9904..b5c9ce4 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -298,7 +298,6 @@ static void i2c_imx_dma_request(struct imx_i2c_struct
> *i2c_imx,
>  	dma->chan_tx = dma_request_slave_channel(dev, "tx");
>  	if (!dma->chan_tx) {
>  		dev_dbg(dev, "can't request DMA tx channel\n");
> -		ret = -ENODEV;
>  		goto fail_al;
>  	}
> 
> @@ -316,7 +315,6 @@ static void i2c_imx_dma_request(struct imx_i2c_struct
> *i2c_imx,
>  	dma->chan_rx = dma_request_slave_channel(dev, "rx");
>  	if (!dma->chan_rx) {
>  		dev_dbg(dev, "can't request DMA rx channel\n");
> -		ret = -ENODEV;
>  		goto fail_tx;
>  	}
> 

Acked-by: Fugang Duan <B38611@xxxxxxxxxxxxx>

Regards,
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux