On Mon, Dec 15, 2014 at 02:37:04PM +0100, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `sh_mobile_i2c_dma_unmap': > i2c-sh_mobile.c:(.text+0x60de42): undefined reference to `dma_unmap_single' > drivers/built-in.o: In function `sh_mobile_i2c_xfer_dma': > i2c-sh_mobile.c:(.text+0x60df22): undefined reference to `dma_map_single' > i2c-sh_mobile.c:(.text+0x60df2e): undefined reference to `dma_mapping_error' > > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Thanks for spotting this. However, since DMA is opt-in, isn't this dependency too much? I can't think of anything better than #ifdeffing the code, though. > --- > drivers/i2c/busses/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index c1351d9fb35bbc8d..f08dd20f625c184d 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -753,6 +753,7 @@ config I2C_SH7760 > > config I2C_SH_MOBILE > tristate "SuperH Mobile I2C Controller" > + depends on HAS_DMA > depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST > help > If you say yes to this option, support will be included for the > -- > 1.9.1 >
Attachment:
signature.asc
Description: Digital signature
