Re: [RFC 0/2] i2c: sh_mobile: don't regress on deferred probing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Wed, Dec 10, 2014 at 2:21 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> Okay, here is my take on solving the problem found by Geert. I still don't like
> it much but it is not as bad as I expected it to be ;) Let me know what you
> think.

Thanks, it's indeed less ugly than I would have expected ;-)

Note that in spi-rspi.c and spi-sh-msiof, any error returned by *_request_dma()
is considered an error, and -EPROBE_DEFER is not handled specially.
So it won't retry if the DMA engine driver isn't available, but just use PIO
(until unbind/bind).

Now we have a nice sample implementation, perhaps I should port it to
spi-rspi and spi-sh-msiof, too?

Let's wait and see for other comments...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux