On 12/05/2014 06:41 AM, rajeev kumar wrote: > On Wed, Dec 3, 2014 at 6:05 PM, Harini Katakam <harinik@xxxxxxxxxx> wrote: >> The I2C controller sends a NACK to the slave when transfer size register >> reaches zero, irrespective of the hold bit. So, in order to handle transfers >> greater than 252 bytes, the transfer size register has to be maintained at a >> value >= 1. This patch implements the same. > > Why 252 Bytes ? Is it word allign or what ? > >> The interrupt status is cleared at the beginning of the isr instead of >> the end, to avoid missing any interrupts - this is in sync with the new >> transfer handling. >> > > No need to write this, actually this is the correct way of handling interrupt. > >> Signed-off-by: Harini Katakam <harinik@xxxxxxxxxx> >> --- >> >> v2: >> No changes >> >> --- >> drivers/i2c/busses/i2c-cadence.c | 156 ++++++++++++++++++++------------------ >> 1 file changed, 81 insertions(+), 75 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c >> index 63f3f03..e54899e 100644 >> --- a/drivers/i2c/busses/i2c-cadence.c >> +++ b/drivers/i2c/busses/i2c-cadence.c >> @@ -126,6 +126,7 @@ >> * @suspended: Flag holding the device's PM status >> * @send_count: Number of bytes still expected to send >> * @recv_count: Number of bytes still expected to receive >> + * @curr_recv_count: Number of bytes to be received in current transfer > > Please do the alignment properly Alignments are correct when you apply this patch. Please let us know if you see any problem. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
