Re: [PATCH 2/2] i2c: Remove support for legacy PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/04/2014 07:11 PM, Wolfram Sang wrote:
On Sun, Nov 30, 2014 at 05:52:32PM +0100, Lars-Peter Clausen wrote:
There haven't been any I2C driver that use the legacy suspend/resume
callbacks for a while now and new drivers are supposed to use PM ops. So
remove support for legacy suspend/resume for I2C drivers.

Since there aren't any special bus specific things to do during
suspend/resume and since the PM core will automatically fallback directly to
using the device's PM ops if no bus PM ops are specified there is no need to
have any I2C bus PM ops.

Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

I'll keep this for 3.20, 3.19 is too close now. But thanks, the diffstat
looks great :) Just curious, has buildbot tested this already?


No, but I did allyesconfig on both ARM and x86. As well as a `grep " i2c_driver " -A20 * -r | grep '\(suspend\|resume\)'` and running the following cocci script.

@@
identifier fn;
identifier drv;
@@
struct i2c_driver drv  = {
    ...,
*   .suspend = fn,
    ...,
};

@@
identifier fn;
identifier drv;
@@
struct i2c_driver drv = {
    ...,
*   .resume = fn,
    ...,
};

None of those methods found anything, so I'm quite confident that there are no users left.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux