On Tue, Dec 02, 2014 at 10:05:49AM +0000, Harini Katakam wrote: > From: Vishnu Motghare <vishnum@xxxxxxxxxx> > > This patch defeatures repeated start in the driver if > "defeature-repeated-start" property is present in the devicetree. > > This defeature is proposed due to a few bugs in the controller > - completion indication is not given to the driver at the end of > a read/receive transfer with HOLD bit set. > - Invalid read transaction are generated on the bus when HW timeout > condition occurs with HOLD bit set. > > Signed-off-by: Vishnu Motghare <vishnum@xxxxxxxxxx> > Signed-off-by: Harini Katakam <harinik@xxxxxxxxxx> > --- > drivers/i2c/busses/i2c-cadence.c | 44 +++++++++++++++++++++++++++----------- > 1 file changed, 31 insertions(+), 13 deletions(-) [...] > @@ -840,6 +856,8 @@ static int cdns_i2c_probe(struct platform_device *pdev) > cdns_i2c_writereg(CDNS_I2C_CR_ACK_EN | CDNS_I2C_CR_NEA | CDNS_I2C_CR_MS, > CDNS_I2C_CR_OFFSET); > > + of_property_read_u32(pdev->dev.of_node, "defeature-repeated-start", > + &id->defeature_repeated_start); This will not work with the binding you described. You want to treat this as a bool, and use of_property_read_bool. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
