Re: [PATCH v3] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hallo,

On Mon, Nov 24, 2014 at 10:55:45AM +0100, Max Schwarz wrote:
> Commit 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes
> correctly") introduced a dependency on clock rate notifiers. Now we get
> compiler errors if compiled without COMMON_CLK:
> 
> drivers/i2c/busses/i2c-rk3x.c: In function 'rk3x_i2c_clk_notifier_cb':
> drivers/i2c/busses/i2c-rk3x.c:634:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
> [...]
> 
> But the driver has always depended on COMMON_CLK even if it compiled
>  - in fact it fails to probe without it. So add that as a Kconfig
> dependency.
> 
> Fixes: 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")
> Signed-off-by: Max Schwarz <max.schwarz@xxxxxxxxx>
> ---
> 
> Wolfram,
> 
> here is a version with *even* better commit msg in case you still want to
> take that instead of my quick fix.
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux