On Mon, Nov 24, 2014 at 10:46:25AM +0100, Max Schwarz wrote:
> Fixes: 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")
This line usually goes into the S-o-B block below. So maybe:
Commit 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes
correctly") introduced a dependency ...
and then the Fixes line above your S-o-b.
>
> which introduced a dependency on clock rate notifiers. Now we get compiler
> errors if compiled without COMMON_CLK:
>
> drivers/i2c/busses/i2c-rk3x.c: In function 'rk3x_i2c_clk_notifier_cb':
> drivers/i2c/busses/i2c-rk3x.c:634:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
> [...]
>
> But the driver has always depended on COMMON_CLK even if it compiled
> - in fact it fails to probe without it. So add that as a Kconfig
> dependency.
>
> Signed-off-by: Max Schwarz <max.schwarz@xxxxxxxxx>
> ---
>
> Wolfram,
>
> here is a version with better commit msg in case you still want to take that
> instead of my quick fix.
Thanks for your quick turn around.
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
