On Mon, Nov 17, 2014 at 06:40:36PM +0800, Yuan Yao wrote: > Add dma support for i2c. This function depend on DMA driver. > You can turn on it by write both the dmas and dma-name properties in dts node. > DMA is optional, even DMA request unsuccessfully, i2c can also work well. > > Signed-off-by: Yuan Yao <yao.yuan@xxxxxxxxxxxxx> gcc found a bug: drivers/i2c/busses/i2c-imx.c:703:7: warning: 'orig_jiffies' may be used uninitialized in this function [-Wuninitialized] drivers/i2c/busses/i2c-imx.c:672:16: note: 'orig_jiffies' was declared here > + result = wait_for_completion_interruptible_timeout( > + &i2c_imx->dma->cmd_complete, > + msecs_to_jiffies(DMA_TIMEOUT)); And are you sure you want to use wait_for_completion_interruptible_timeout() instead of wait_for_completion_timeout() here? Unless you confirm you tested it a lot with signals, I really cannot recommend the *_interruptible_* version. Other than that, good. I liked the logfile of what you tested very much! Thanks, Wolfram
Attachment:
signature.asc
Description: Digital signature
