Re: [PATCH v6 1/2] i2c: Add Imagination Technologies I2C SCB driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Very close to go...

checkpatch --strict says:

CHECK: Please don't use multiple blank lines
#234: FILE: drivers/i2c/busses/i2c-img-scb.c:181:
+
+

CHECK: Blank lines aren't necessary before a close brace '}'
#621: FILE: drivers/i2c/busses/i2c-img-scb.c:568:
+
+	}

CHECK: braces {} should be used on all arms of this statement
#810: FILE: drivers/i2c/busses/i2c-img-scb.c:757:
+			if (i2c->msg.len == 0)
[...]
+			else if (i2c->msg.flags & I2C_M_RD)
[...]
+			else {
[...]

And coccicheck:

drivers/i2c/busses/i2c-img-scb.c:510:1-12: WARNING: Assignment of bool to 0/1

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux