On Tue, 11 Nov 2014, Octavian Purdila wrote:
> If wait_for_completion_interruptible_timeout returns a positive value
> it may be propagated as the return value of _dln2_transfer. This
> contradicts the documentation of the function and exposes unnecessary
> internals to the callers.
>
> This patch makes sure to set the return value to 0 in that case.
I didn't keep around the code or the address of the git tree, but I wonder
if this makes a later assignment of ret to 0 unnecessary?
julia
> Reported-by: Julia Lawall <julia.lawall@xxxxxxx>
> Signed-off-by: Octavian Purdila <octavian.purdila@xxxxxxxxx>
> ---
> drivers/mfd/dln2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
> index 9765a17..f0747a1 100644
> --- a/drivers/mfd/dln2.c
> +++ b/drivers/mfd/dln2.c
> @@ -462,7 +462,8 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
> if (!ret)
> ret = -ETIMEDOUT;
> goto out_free_rx_slot;
> - }
> + } else
> + ret = 0;
>
> if (dln2->disconnect) {
> ret = -ENODEV;
> --
> 1.9.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
