Hi Ezequiel,
On 04.11.2014 22:37, Ezequiel Garcia wrote:
> From: James Hogan <james.hogan@xxxxxxxxxx>
>
> Add support for the IMG I2C Serial Control Bus (SCB) found on the
> Pistachio and TZ1090 SoCs.
>
> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> [Ezequiel: code cleaning and rebasing]
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx>
> ---
> drivers/i2c/busses/Kconfig | 10 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-img-scb.c | 1410 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 1421 insertions(+)
> create mode 100644 drivers/i2c/busses/i2c-img-scb.c
>
> diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
> new file mode 100644
> index 0000000..79ad85e
> --- /dev/null
> +++ b/drivers/i2c/busses/i2c-img-scb.c
> @@ -0,0 +1,1410 @@
> +/*
> + * I2C adapter for the IMG Serial Control Bus (SCB) IP block.
> + *
[snip]
> + /*
> + * Get the bus number from the devicetree. Other I2C adapters may be
> + * reserved for non-Linux core. Instead of letting Linux pick any
> + * number, it's useful to fix the bus number so users get a consistent
> + * view.
> + */
> + ret = of_property_read_u32(node, "linux,i2c-index", &val);
> + if (!ret)
> + i2c->adap.nr = val;
> + else
> + i2c->adap.nr = pdev->id;
> +
if I'm not mistaken "linux,i2c-index" property is redundant, talking
about Linux you can set up an arbitrary bus number by specifying a DTS
alias.
Most probably just
i2c->adap.nr = pdev->id;
may serve your purposes.
[snip]
> +
> + ret = i2c_add_numbered_adapter(&i2c->adap);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to add adapter\n");
> + goto disable_clk;
> + }
> +
> + return 0;
> +
> +disable_clk:
> + clk_disable_unprepare(i2c->sys_clk);
> + return ret;
> +}
> +
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
