Re: [PATCH] ARM: shmobile: koelsch: Remove non-existent i2c6 pinmux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

On Tue, Aug 12, 2014 at 3:36 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Tue, Aug 12, 2014 at 03:03:13PM +0200, Geert Uytterhoeven wrote:
>> On r8a7791, i2c6 (aka iic3) doesn't need pinmux, but the koelsch dts
>> refers to non-existent pinmux configuration data:
>>
>> pinmux core: sh-pfc does not support function i2c6
>> sh-pfc e6060000.pfc: invalid function i2c6 in map table
>>
>> Remove it to fix this.
>>
>> Fixes: commit 1d41f36a68c0f4e9b01d563ce33bab5201858b54 ("ARM: shmobile:
>>        koelsch dts: Add VDD MPU regulator for DVFS")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Thanks Geert. Does this manifest as a run-time problem?

I don't think it causes any harm, despite the error message.
i2c6 works fine (using a modified version of "ARM: shmobile:
koelsch-reference: Add restart function" from the BSP).

> Regardless, it looks like I should queue this up as
> a fix for v3.17. Is that your thinking too?

The error message is a regression from v3.16, so v3.17 would be
appropriate. However, if you have no other DTS fixes for v3.17,
v3.18 is fine for me, too.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux