On 2014年08月10日 01:34, Linus Torvalds wrote: > On Sat, Aug 9, 2014 at 6:56 AM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: >> >> here is the pull request for 3.17 for the I2C subsystem. Highlights: > > Lowlight: selecting ACPI support (which used to be the default if ACPI > was enabled) now forces i2c to be built-in. > > I've pulled this, but it's broken. You need to fix it someway. > > The reason for this is > > config I2C > tristate "I2C support" > ... > config I2C_ACPI > bool "I2C ACPI support" > select I2C > depends on ACPI > ... > > where if I2C_APCI is on (y), then that "select I2C" will cause I2C to > be upgraded to 'y' as well. > > This seems to be intentional, judging by the commit message, but it's > wrong. Distributions etc generally compile i2c as a module, and you've > now broken that. > > This is a regression. Change the "select I2C" to a "depends on I2C", > and test the end result. Don't force people to build things into the > kernel. Hi Linus: Sorry about this, I will create a fix patch soon. Thanks. > > Linus > -- Best regards Tianyu Lan -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html