Thanks for your review. Varka Bhadram wrote: > On 08/05/2014 03:26 PM, Yuan Yao wrote: > > (...) > > +fail_rx: > > + dma_release_channel(dma->chan_rx); > > +fail_tx: > > + dma_release_channel(dma->chan_tx); > > +fail_al: > > + devm_kfree(dev, dma); > > no need to use devm_kfree() if we use devm_kzalloc()... > We have discussed it before. As Lothar Waßmann said: "The devm_kfree() is not in the failure path of the driver's probe() function, but in the function that tries to initialize the optional DMA support." So It seems need to use devm_kfree(). Do you have some other opinions? > > + dev_info(dev, "can't use DMA\n"); > > + > > + return ret; > > +} (...) > > +static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, > > + struct i2c_msg *msgs) > > static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, > struct i2c_msg *msgs) > > run checkpatch.pl on this patch... Sorry for my code style. I will match open parenthesis in this case. I had run this script before, just one warning. > -- > Regards, > Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
