On 07/23/2014 04:41 PM, Yao Yuan wrote:
Hi,
Thanks for your review.
Lothar Waßmann wrote:
Yuan Yao wrote:
Add dma support for i2c. This function depend on DMA driver.
You can turn on it by write both the dmas and dma-name properties in dts node.
Signed-off-by: Yuan Yao <yao.yuan@xxxxxxxxxxxxx>
---
drivers/i2c/busses/i2c-imx.c | 377
[...]
+
+fail_rx:
+ dma_release_channel(dma->chan_rx);
+fail_tx:
+ dma_release_channel(dma->chan_tx);
+fail_al:
+ devm_kfree(dev, dma);
No need for this one (that's the whole point of using devm_kzalloc())!
When DMA request failed, I2C will switch to PIO mode. So if the failed reason is just like DMA channel request failed. At this time the DMA should free by devm_kfree(). Is it?
If probe failed the memory will be freed automatically because
we are using devm_kzalloc()...
If we use devm_kzalloc() ,no need to free manually on fail...
--
Regards,
Varka Bhadram.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
