On Mon, Jun 23, 2014 at 5:38 PM, Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote: > > On 23/06/2014 13:13, Sachin Kamat wrote: >> module.h was included twice. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx> > > >> --- >> drivers/i2c/busses/i2c-sun6i-p2wi.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c >> index 09de4fd12d57..558fd24573b2 100644 >> --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c >> +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c >> @@ -26,7 +26,6 @@ >> #include <linux/i2c.h> >> #include <linux/io.h> >> #include <linux/interrupt.h> >> -#include <linux/module.h> > > Oops, I guess this was introduced when I reordered inclusions in > alphabetic order. > I'd prefer the other inclusion to be removed instead, so that we could > keep it in alphabetic order. Sorry, I did not notice that the headers were sorted alphabetically. In such situations (duplicate inclusions), I generally retain the first entry and delete the subsequent ones. However, in this case it doesn't make sense to break the order. > Other than that you have my: > > Acked-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> Thanks. I will respin with your ack. Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
