On 06/03/2014 09:11 AM, Wolfram Sang wrote: >>>> --- a/drivers/i2c/busses/i2c-mpc.c >>>> +++ b/drivers/i2c/busses/i2c-mpc.c >>>> @@ -107,6 +107,7 @@ static irqreturn_t mpc_i2c_isr(int irq, void *dev_id) >>>> static void mpc_i2c_fixup(struct mpc_i2c *i2c) >>>> { >>>> int k; >>>> + u8 dr; >>> >>> Looks like we can drop this variable since the value read is not used? >> >> That's correct it is not used. I have added it to make sure that this is not >> "optimized" out but I guess the readb call is enough for this purpose ? > > I'd think so, but it needs your test :) > I have just tested it and it's OK without the dr variable as well. Sending V2 right now. Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html