Re: [PATCH 1/4] i2c: designware: No need to disable already disabled controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 02, 2014 at 08:34:08PM +0300, Mika Westerberg wrote:
> On Mon, Jun 02, 2014 at 06:12:34PM +0200, Wolfram Sang wrote:
> > On Thu, May 15, 2014 at 05:37:21PM +0300, Mika Westerberg wrote:
> > > If the controller is already in desired state (enabled/disabled) there is
> > > no point in setting its state again.
> > > 
> > > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > > ---
> > 
> > Does it have a side-effect when setting then enable bit again? Otherwise
> > it will exit the loop immediately on the first try. Not too bad IMO
> > given the additional code saved.
> 
> AFAICT there shouldn't be any side effect. So the $subject patch just
> saves one register write in the best case. You are right, maybe it's not
> worth adding 3 extra lines of code just for that :)

:) Okay, so I'll drop it.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux