On Sat, May 10, 2014 at 04:20:14PM +0900, Pankaj Dubey wrote: > Let's handle i2c interrupt re-configuration in i2c driver. This will > help us in removing some soc specific checks from machine files. > Since only Exynos5250, and Exynos5420 need to do this, added syscon > based phandle to i2c device nodes of respective SoC DT files. > Also handle saving and restoring of SYS_I2C_CFG register during > suspend and resume of i2c driver. This will help in removing soc > specific check from mach-exynos/pm.c. > > CC: Rob Herring <robh+dt@xxxxxxxxxx> > CC: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > CC: Wolfram Sang <wsa@xxxxxxxxxxxxx> > CC: Russell King <linux@xxxxxxxxxxxxxxxx> > CC: devicetree@xxxxxxxxxxxxxxx > CC: linux-doc@xxxxxxxxxxxxxxx > CC: linux-i2c@xxxxxxxxxxxxxxx > Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> Shall this go via i2c-tree? Looks to me like it should go with the rest of the series? Patch is mostly okay (only reviewed the code, not the bindings), one nit: > + regmap_update_bits(i2c->sysreg, EXYNOS5_SYS_I2C_CFG, BIT(id), val); Hardcode the '0' and drop using 'val'?
Attachment:
signature.asc
Description: Digital signature
