Hi Wolfram, On Thu, May 22, 2014 at 7:13 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > On Thu, May 22, 2014 at 05:33:39PM +0800, Sonic Zhang wrote: >> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx> >> >> No need to free managed resources any more. >> >> Signed-off-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx> >> >> --- >> v2-changes: >> - Remove resource checking. devm_ioremap_resource will do it. >> - Remove cast of the return value. >> - Remove free_irq from the module remove function. > > How did you test it? > root:/> modprobe i2c-bfin-twi i2c-bfin-twi i2c-bfin-twi.0: Blackfin on-chip I2C TWI Contoller, regs_base@ffc01e00 i2c-bfin-twi i2c-bfin-twi.1: Blackfin on-chip I2C TWI Contoller, regs_base@ffc01f00 root:/> random: nonblocking pool is initialized root:/> lsmod Module Size Used by i2c_bfin_twi 4322 0 root:/> rmmod i2c-bfin-twi root:/> lsmod Module Size Used by root:/> root:/> modprobe i2c-bfin-twi i2c-bfin-twi i2c-bfin-twi.0: Blackfin on-chip I2C TWI Contoller, regs_base@ffc01e00 i2c-bfin-twi i2c-bfin-twi.1: Blackfin on-chip I2C TWI Contoller, regs_base@ffc01f00 root:/> ls /dev/i2c-* /dev/i2c-0 /dev/i2c-1 root:/> rmmod i2c-bfin-twi root:/> ls /dev/i2c-* ls: /dev/i2c-*: No such file or directory root:/> Regards, Sonnic -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
