On 05/17/2014 05:41 PM, Wolfram Sang wrote:
On Mon, Apr 28, 2014 at 10:27:44PM +0800, Lan Tianyu wrote:
Add i2c_smbus_quick_write/read() helper function. These will be used
in the implementation of i2c ACPI address space handler.
Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>
We had such a function once but removed because of no users. Please
check 67c2e66571c383404a5acd08189194da660da942 what it takes to bring
them back. Especially missing are documentation updates...
+s32 i2c_smbus_quick_write(const struct i2c_client *client)
... and I like the original function much better.
1) It is named *_write_quick which follows other function name patterns
2) It uses a parameter for the r/w bit. Make sense to me, since this bit
is the information we send to the device. quick_read doesn't make sense
to me. We don't receive a bit from the device.
Hi Wolfram:
Great thanks for your review. Ok. I will follow commit 67c2e665 to bring
i2c_smbus_write_quick(struct i2c_client *client, u8 value) back.
BTW, how about i2c_probe_func_quick_read()? Should we replace it with the
original i2c_smbus_write_quick()?
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
