On 04/09/2014 01:59 PM, Matthew Garrett wrote: > On Wed, 2014-04-09 at 13:55 -0400, Prarit Bhargava wrote: >> >> On 04/09/2014 01:37 PM, Matthew Garrett wrote: >>> Right. It's dangerous, which is why we forbid it by default. How do we >>> benefit from having a driver that's no safer? >> >> We have yet to see where the existing case exhibits the behaviour of a race. In >> fact, AFAICT, all we've seen is stability. So it's no safer? Yep. It's as >> equally not racy as the existing workaround. > > So... why add the driver at all? Refusing to permit the kernel to touch > these resources is a deliberate design choice, because of the potential > for these races. It'll work absolutely fine right up until the point > where you end up reading the wrong temperature value from an i2c hwmon > chip and perform a critical thermal shutdown. Because it seems like the "right" thing to do is use the ACPI interface rather than the i801 pci driver. At least to me that makes sense. OTOH, if Jean thinks there isn't a need I can drop it. P. > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
