re: i2c: nomadik: Convert to devm functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Ulf Hansson,

The patch 9b2b98a3b4de: "i2c: nomadik: Convert to devm functions"
from Feb 18, 2014, leads to the following static checker warning:

	drivers/i2c/busses/i2c-nomadik.c:1002 nmk_i2c_probe()
	warn: 'dev->virtbase' isn't an ERR_PTR

drivers/i2c/busses/i2c-nomadik.c
   999  
  1000          dev->virtbase = devm_ioremap(&adev->dev, adev->res.start,
  1001                                  resource_size(&adev->res));
  1002          if (IS_ERR(dev->virtbase)) {
                    ^^^^^^^^^^^^^^^^^^^^
devm_ioremap() returns a NULL on error the same as ioremap() does.

  1003                  ret = -ENOMEM;
  1004                  goto err_no_mem;
  1005          }
  1006  
  1007          dev->irq = adev->irq[0];

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux