On 09/23/2013 12:10 AM, Wolfram Sang wrote:
>
>> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
>> index b80c768..55dce43 100644
>> --- a/drivers/i2c/busses/i2c-mpc.c
>> +++ b/drivers/i2c/busses/i2c-mpc.c
>> @@ -106,7 +106,12 @@ static irqreturn_t mpc_i2c_isr(int irq, void *dev_id)
>> static void mpc_i2c_fixup(struct mpc_i2c *i2c)
>> {
>> int k;
>> - u32 delay_val = 1000000 / i2c->real_clk + 1;
>> + u32 delay_val;
>> +#ifdef CONFIG_PPC_85xx
>> + delay_val = 65536 / (fsl_get_sys_freq() / 2000000); /* 64K cycle */
>> +#else
>> + delay_val = 1000000 / i2c->real_clk + 1;
>> +#endif
>
> Please, no unnecessary #ifdefs in code. We have 'struct mpc_i2c_data'
> already.
>
I am not pround of this change. Please elaborate how to use mpc_i2c_data
to separate the mpc85xx from the rest.
York
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
