Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 05, 2013 at 12:23:44PM -0700, Olof Johansson wrote:
> commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
> of this one case:
> 
> drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
> drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
> 	'dev_get_platdata' from incompatible pointer type [enabled by default]
> 
> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Signed-off-by: Olof Johansson <olof@xxxxxxxxx>

Gosh, need to find out why my build-tests failed on that. Thanks!

Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>

Jingoo Han: Did you buildtest?

> ---
>  drivers/i2c/busses/i2c-davinci.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 5747341..132369f 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -662,7 +662,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
>  #endif
>  	dev->dev = &pdev->dev;
>  	dev->irq = irq->start;
> -	dev->pdata = dev_get_platdata(&dev->dev);
> +	dev->pdata = dev_get_platdata(&pdev->dev);
>  	platform_set_drvdata(pdev, dev);
>  
>  	if (!dev->pdata && pdev->dev.of_node) {
> -- 
> 1.7.10.4
> 

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux