On 13-08-28 05:57 PM, Wolfram Sang wrote:
On Tue, Aug 20, 2013 at 04:32:28PM +0800, Zhangfei Gao wrote:
Instead of use platform_driver_probe, use module_platform_driver
To support deferred probing
Also subsys_initcall may too early to auto set pinctl
Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
Acked-by: Baruch Siach <baruch@xxxxxxxxxx>
This patch is tougher than it looks. You need it, because
subsys_initcall may be too early for pinctrl. Other people might be
depending on subsys_initcall to get I2C active before they want to
activate, say, PMICs. So, I fear regressions, since deferred probing
might not be available in the needed places to avoid these regressions.
I am all ears for a nice transition away from subsys_initcall, anyone?
Dear Wolfram,
The deferred probe will be successful if change platform_driver_probe to
platform_driver_register, to register itself to drv name list.
However, the effect is subsys_initcall is postponed, until pin control
driver is probed successfully.
If the pin is specific and does not need configure, there is no issue.
There may still have issue if the mulit-function pin need be configured
via pinctrl, except put pin control driver earlier too.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
