On 29/08/13 11:24, Ben Dooks wrote:
On 29/08/13 06:33, Magnus Damm wrote:
Hi Ian,
Thanks for submitting this patch. I have one comment only, please see
below.
+#ifdef CONFIG_I2C_EMXX_SMC
+ i2c_dev->flags |= I2C_BIT_SMC0;
+#endif
I think CONFIG_I2C_EMXX_SMC probably want to be reworked somehow. I
assume it's an old left over in this particular case. But if you need
to have some special configuration method then please consider some
other way than CONFIG_ variables that are not very compatible with
future multi-platform kernel images.
Is it something that needs to be passed through the device tree binding
or something we can detect from the SoC itself?
Probably. Its the switch to select between 100 and 400kHz modes.
I wonder if theres a standard binding for it?
-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
