> >> @@ -326,6 +463,12 @@ mv64xxx_i2c_do_action(struct mv64xxx_i2c_data *drv_data) > >> drv_data->reg_base + drv_data->reg_offsets.control); > >> break; > >> > >> + case MV64XXX_I2C_ACTION_OFFLOAD_SEND_START: > >> + if (mv64xxx_i2c_offload_msg(drv_data) <= 0) > > > > needs to be adjusted when using -EINVAL above. I'd prefer the error case > > in the else branch, though. Easier to read. > > > > OK, but in this case ... > > >> + break; > >> + else > >> + drv_data->action = MV64XXX_I2C_ACTION_SEND_START; > >> + /* FALLTHRU */ > > ... the fall through here is less readable. But it is a matter of > taste, I will change this. Ah, I see. Well, try both and decide. Thanks!
Attachment:
signature.asc
Description: Digital signature
