On Thu, Jul 25, 2013 at 04:59:25PM -0400, Santosh Shilimkar wrote: > On Thursday 25 July 2013 05:40 AM, Sekhar Nori wrote: > > On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote: > >> This driver no longer uses definitions from mach/hardware.h. > >> On the other hand, including this header breaks this driver > >> on non-davinci platforms which don't have such a header. > >> > >> Fix it. > >> > >> Cc: Sekhar Nori <nsekhar@xxxxxx> > >> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > >> > >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > > > Acked-by: Sekhar Nori <nsekhar@xxxxxx> > > > > One minor nit: > > > >> --- > >> drivers/i2c/busses/i2c-davinci.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c > >> index fa55605..ddaa2a3 100644 > >> --- a/drivers/i2c/busses/i2c-davinci.c > >> +++ b/drivers/i2c/busses/i2c-davinci.c > >> @@ -41,7 +41,6 @@ > >> #include <linux/of_i2c.h> > >> #include <linux/of_device.h> > >> > > > > You can now remove this empty line too. > > > Yes. Updated patch below with your ack added. > > Regards, > Santosh > > From d7ae1c488ebae19028f33abff76c4d684271a7fb Mon Sep 17 00:00:00 2001 > From: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > Date: Tue, 23 Jul 2013 15:40:46 -0400 > Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include > > This driver no longer uses definitions from mach/hardware.h. > On the other hand, including this header breaks this driver > on non-davinci platforms which don't have such a header. > > Fix it. Applied to for-next, thanks! Please send a proper V2 in a seperate message next time.
Attachment:
signature.asc
Description: Digital signature
