Re: [PATCH] i2c: mxs: Better error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote:
> This patch fixes two error handling cases in mxs_i2c_xfer_msg():
> 
>  - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but i2c->cmd_err
>  will not be set so mxs_i2c_xfer_msg() fails silently.
> 
>  - in DMA mode, mxs_i2c_dma_setup_xfer() may return an error and have
>  i2c->cmd_err set to -ENXIO. In that case, we want to go through the
>  MXS_I2C_CTRL1_CLR_GOT_A_NAK before returning.

A short explanation why we want that would be perfect.

> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>

I'd like to postpone this until I applied Marek's PIO rework. Could you
respin after that?

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux