On Tue, Jul 02, 2013 at 10:10:29AM +0800, James Lebron wrote: > Hi Wolfram > > Have you finished reading datasheet? Sadly not. I couldn't find the reference manual freely available. That was a problem when reviewing this patch. > 1. High speed mode is hardware feature, you can't read it from > software. It's similar to fast mode, and fast mode is set in platform > data. Yes, setting fast mode in platform_data is troublesome, too. Better would be to introduce a new platform_id (say, pxa910-i2c) and to deduce from that id that only this version has high speed mode. I am accepting the current solution since it is consistent with fast mode, but all this needs to be fixed if pxa is going devicetree. Thanks, Wolfram
Attachment:
signature.asc
Description: Digital signature
