> Using a struct type with a div and regval member would make the code > surrounding this array more obviously correct. Would be nice to > straighten this first before adding another array. > > How about adding a regshift member instead? It seems shifting the vybrid > registers by two bits is the imx registers. [Lu Jingchang-B35083] Yes, using a struct for the i2c clock {div, regval} pairs would be more readable, and the registers indeed have the same address offset. I'll make some change and send the v3 patch. Thanks! Best Regards, Jingchang -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html