On Fri, Jun 28, 2013 at 02:35:52PM -0700, Kevin Hilman wrote: > There has long been a syntax problem in iop3xx_i2c_wait_event() which > has been somehow hidden by the macros in <linux/wait.h>. After some > recent cleanup/rework of the wait_event_* helpers, the bug has come > out from hiding and now results in build failure: > > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c: In function 'iop3xx_i2c_wait_event': > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c:176:143: error: expected ')' before ';' token > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c:176:157: error: expected ')' before ';' token > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c:176:213: error: expected ')' before ';' token > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c:176:291: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c:176:551: error: expected ')' before ';' token > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c:176:565: error: expected ')' before ';' token > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c:176:764: error: expected ')' before ';' token > /work/kernel/next/drivers/i2c/busses/i2c-iop3xx.c:176:778: error: expected ')' b > > Fix by removing stray ';' > > Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxx> Applied to for-next, thanks! (Geez, that original code looks ugly...)
Attachment:
signature.asc
Description: Digital signature
