On Fri, Jun 21, 2013 at 04:15:29PM +0200, Sebastian Hesselbarth wrote: > from a quick check of the patch set (which you forgot to send to LKML) > I am wondering why you didn't update the of matches struct with the new > compatible for "marvell,mv78230-i2c"? This will save you from still > having "marvell,mv64xxx-i2c" as additional compatible to match device > and driver. With that the above should also be s/and/or/. Agree, I noticed the same things. Alos, the compatible string should be: compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c"; (note the order reversal, most specific is first) and I think it is better to use the 'data' field of of_device_id than a of_is_compatible call. The former is sensitive to order of the compatible string, the latter is not. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
