On Fri, Jun 07, 2013 at 06:25:00PM +0200, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
>
> On Fri, 7 Jun 2013 17:48:59 +0200, Gregory CLEMENT wrote:
>
> > +/*
> > + * 5us delay in order to avoid repeated start
> > + * timing violation on Armada XP SoC.
> > + */
> > +static int mv64xxx_i2c_errata_delay;
>
> This should probably be a per-I2C controller variable, i.e in
> mv64xxx_i2c_data.
Yes.
>
>
> > + if (!mv64xxx_i2c_errata_delay &&
> > + of_machine_is_compatible("marvell,armadaxp"))
> > + mv64xxx_i2c_errata_delay = 1;
>
> I am wondering whether it should be done this way, or using a separate
> DT property.
Need to think about it. It is similar to the sda-hold-time issue, I
guess.
Attachment:
signature.asc
Description: Digital signature
