On Fri, May 17, 2013 at 08:37:43AM +0200, Jean-Francois Moine wrote: > On Thu, 16 May 2013 21:30:59 +0100 > Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> wrote: > > > Do not use interruptible waits in an I2C driver; if a process uses > > signals (eg, Xorg uses SIGALRM and SIGPIPE) then these signals can > > cause the I2C driver to abort a transaction in progress by another > > driver, which can cause that driver to fail. I2C drivers are not > > expected to abort transactions on signals. > > Hi Russell, > > I had the same problem with my dove drm driver, but I don't fully agree > with your solution. > > Using wait_event_timeout() stops the system, and reading the EDID from > an external screen may take some time. It doesn't stop the system. It stops the process until that has completed. Using the DRM TDA19988 driver, things are nice and quick while reading the EDID, because it does reads an entire EDID block using one message. Blocking the signals like you do has exactly the same effect - you prevent the I2C driver being interrupted by signals. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
